Remove deprecated cassandra flags #2789
Conversation
Signed-off-by: albertteoh <albert.teoh@logz.io>
| @@ -44,7 +44,6 @@ type Configuration struct { | |||
| Port int `yaml:"port" mapstructure:"port"` | |||
| Authenticator Authenticator `yaml:"authenticator" mapstructure:",squash"` | |||
| DisableAutoDiscovery bool `yaml:"disable_auto_discovery" mapstructure:"-"` | |||
| EnableDependenciesV2 bool `yaml:"enable_dependencies_v2" mapstructure:"-"` | |||
There was a problem hiding this comment.
I expect there to be some code that actually reads this field, not seeing anything like that removed in the PR.
There was a problem hiding this comment.
Did a recursive case-insensitive search in my jaeger root project dir and couldn't find EnableDependenciesV2 or enable_dependencies_v2.
Maybe something wrong with my search, can you see any references?
There was a problem hiding this comment.
found it - the logic for that flag was already removed in #1364
Codecov Report
@@ Coverage Diff @@
## master #2789 +/- ##
==========================================
- Coverage 95.88% 95.83% -0.05%
==========================================
Files 218 218
Lines 9626 9615 -11
==========================================
- Hits 9230 9215 -15
- Misses 327 330 +3
- Partials 69 70 +1
Continue to review full report at Codecov.
|
Signed-off-by: albertteoh <albert.teoh@logz.io>
Signed-off-by: albertteoh <albert.teoh@logz.io>
* Remove deprecated cassandra flags Signed-off-by: albertteoh <albert.teoh@logz.io> * Add breaking changelog entry Signed-off-by: albertteoh <albert.teoh@logz.io> * Fix wording; doesn't technically replace Signed-off-by: albertteoh <albert.teoh@logz.io>
Signed-off-by: albertteoh albert.teoh@logz.io
Which problem is this PR solving?
Short description of the changes